Changeset 353 for kraken-cron/src

Timestamp:

10/17/09 16:31:47 (11 months ago)

Author:

periphery

Message:

minor modification made on kraken-cron.
Statement is changed to PreparedStatement to prevent SQL injection.

Location:

kraken-cron/src/main/java/org/krakenapps/cron

Files:

• CronScript.java (modified) (2 diffs)
• CronService.java (modified) (1 diff)
• impl/CronConfig.java (modified) (2 diffs)
• impl/CronServiceImpl.java (modified) (1 diff)

kraken-cron/src/main/java/org/krakenapps/cron/CronScript.java

@@ -90 +90 @@
                 } catch (NumberFormatException e) {
                         context.println("USAGE : SCHEDULE_ID");
-                } catch (NoSuchElementException e){
+                } catch (NoSuchElementException e) {
                         context.println("cron script: no schedule of given id %d", Integer.parseInt(args[0]));
                 }
@@ -162 +162 @@
         }
 
+
 }

kraken-cron/src/main/java/org/krakenapps/cron/CronService.java

@@ -10 +10 @@
  */
 public interface CronService {
-        void registerSchedule(Schedule schedule);
+
+        int registerSchedule(Schedule schedule);
 
         void unregisterSchedule(int i);

kraken-cron/src/main/java/org/krakenapps/cron/impl/CronConfig.java

@@ -116 +116 @@
         private int update(String expression) {
                 Statement st = null;
+                PreparedStatement pst = null;
                 int autoIncKeyFromApi = -1;
                 try {
                         connect();
+                        pst = connection.prepareStatement(expression);
+                        pst.execute();
                         st = connection.createStatement();
-                        st.executeUpdate(expression);
                     ResultSet rs = st.executeQuery("CALL IDENTITY()");
                     if (rs.next()) {
@@ -130 +132 @@
                 } catch (Exception e) {
                         logger.debug("CronConfig : exception raised during " + expression + ". IGNORED.");
+                        e.printStackTrace();
                         rollback();
                 } finally {

kraken-cron/src/main/java/org/krakenapps/cron/impl/CronServiceImpl.java

@@ -42 +42 @@
          */
         @Override
-        public void registerSchedule(Schedule schedule) {
+        public int registerSchedule(Schedule schedule) {
                 int id = config.addEntry(schedule);
                 this.map.put(id, schedule);
                 scheduler.put(id, schedule);
+                return id;
         }